From 0194a4e006c6a19d77e4e3d3c357d18654e18a35 Mon Sep 17 00:00:00 2001
From: RunasSudo <runassudo@yingtongli.me>
Date: Fri, 16 Aug 2024 22:21:10 +1000
Subject: [PATCH] Fix bug where cancelling deletion confirmation would not work

---
 drcr/templates/journal/balance_assertions_edit.html  | 2 +-
 drcr/templates/journal/journal_edit_transaction.html | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drcr/templates/journal/balance_assertions_edit.html b/drcr/templates/journal/balance_assertions_edit.html
index 185e985..57bf901 100644
--- a/drcr/templates/journal/balance_assertions_edit.html
+++ b/drcr/templates/journal/balance_assertions_edit.html
@@ -57,7 +57,7 @@
 			
 			<div class="flex justify-end mt-4 space-x-2">
 				{% if assertion and assertion.id %}
-					<button type="submit" name="action" value="delete" class="btn-secondary text-red-600 ring-red-500" onclick="confirm('Are you sure you want to delete this balance assertion? This operation is irreversible.')">Delete</button>
+					<button type="submit" name="action" value="delete" class="btn-secondary text-red-600 ring-red-500" onclick="return confirm('Are you sure you want to delete this balance assertion? This operation is irreversible.');">Delete</button>
 				{% endif %}
 				<button type="submit" class="btn-primary">Save</button>
 			</div>
diff --git a/drcr/templates/journal/journal_edit_transaction.html b/drcr/templates/journal/journal_edit_transaction.html
index c86f0e7..8d1e270 100644
--- a/drcr/templates/journal/journal_edit_transaction.html
+++ b/drcr/templates/journal/journal_edit_transaction.html
@@ -176,7 +176,7 @@
 		
 		<div class="flex justify-end mt-4 space-x-2">
 			{% if transaction and transaction.id %}
-				<button type="submit" name="action" value="delete" class="btn-secondary text-red-600 ring-red-500" onclick="confirm('Are you sure you want to delete this transaction? This operation is irreversible.')">Delete</button>
+				<button type="submit" name="action" value="delete" class="btn-secondary text-red-600 ring-red-500" onclick="return confirm('Are you sure you want to delete this transaction? This operation is irreversible.');">Delete</button>
 			{% endif %}
 			<button type="submit" class="btn-primary">Save</button>
 		</div>