From 156a89e2ba435f1ababebde17fa0ffc8505c922f Mon Sep 17 00:00:00 2001
From: RunasSudo <runassudo@yingtongli.me>
Date: Sat, 15 Feb 2025 22:54:59 +1100
Subject: [PATCH] Fix race condition in income statement report view

---
 src/reports/IncomeStatementReport.vue | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/src/reports/IncomeStatementReport.vue b/src/reports/IncomeStatementReport.vue
index 9f20988..0c5aca8 100644
--- a/src/reports/IncomeStatementReport.vue
+++ b/src/reports/IncomeStatementReport.vue
@@ -90,6 +90,13 @@
 		dtStart.value = dayjs(db.metadata.eofy_date).subtract(1, 'year').add(1, 'day').format('YYYY-MM-DD');
 		
 		await updateReport(session);
+		
+		// Update report when dates etc. changed
+		// We initialise the watcher here only after dt and dtStart are initialised above
+		watch([dt, dtStart], async () => {
+			const session = await db.load();
+			await updateReport(session);
+		});
 	}
 	
 	async function updateReport(session: ExtendedDatabase) {
@@ -99,11 +106,5 @@
 		report.value = reportingWorkflow.getReportAtStage(ReportingStage.InterimIncomeStatement, IncomeStatementReport) as IncomeStatementReport;
 	}
 	
-	// Update report when dates etc. changed
-	watch([dt, dtStart], async () => {
-		const session = await db.load();
-		updateReport(session);
-	});
-	
 	load();
 </script>