RunasSudo/DrCr
1
Fork 0
Code Issues 1 Pull Requests Releases Activity

austax: Declare account name magic strings as constants

Browse Source
This commit is contained in:
RunasSudo 2025-06-02 20:10:03 +10:00
parent a0071cf120
commit 1a5167acf5
Signed by: RunasSudo
GPG Key ID: 7234E476BF21C61A
1 changed files with 17 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
libdrcr/plugins/austax/reporting.luau
View File

@ -19,8 +19,18 @@ local libdrcr = require('../libdrcr')
local account_kinds = require('../austax/account_kinds') local account_kinds = require('../austax/account_kinds')
local calc = require('../austax/calc') local calc = require('../austax/calc')
-- Account constants
local CURRENT_YEAR_EARNINGS = 'Current Year Earnings'
local HELP = 'HELP'
local INCOME_TAX = 'Income Tax'
local INCOME_TAX_CONTROL = 'Income Tax Control'
local RETAINED_EARNINGS = 'Retained Earnings'
local reporting = {} local reporting = {}
-- This ReportingStep calculates income tax
--
-- Generates the tax summary DynamicReport, and adds Transactions reconciling income tax expense, PAYG withholding and study loan repayments.
reporting.CalculateIncomeTax = { reporting.CalculateIncomeTax = {
name = 'CalculateIncomeTax', name = 'CalculateIncomeTax',
product_kinds = {'DynamicReport', 'Transactions'}, product_kinds = {'DynamicReport', 'Transactions'},
@ -378,7 +388,7 @@ function reporting.CalculateIncomeTax.execute(args, context, kinds_for_account,
id = nil, id = nil,
transaction_id = nil, transaction_id = nil,
description = nil, description = nil,
account = 'Income Tax', account = INCOME_TAX,
quantity = (tax_total - offset_total), quantity = (tax_total - offset_total),
commodity = context.reporting_commodity, commodity = context.reporting_commodity,
quantity_ascost = (tax_total - offset_total), quantity_ascost = (tax_total - offset_total),
@ -387,7 +397,7 @@ function reporting.CalculateIncomeTax.execute(args, context, kinds_for_account,
id = nil, id = nil,
transaction_id = nil, transaction_id = nil,
description = nil, description = nil,
account = 'Income Tax Control', account = INCOME_TAX_CONTROL,
quantity = -(tax_total - offset_total), quantity = -(tax_total - offset_total),
commodity = context.reporting_commodity, commodity = context.reporting_commodity,
quantity_ascost = -(tax_total - offset_total), quantity_ascost = -(tax_total - offset_total),
@ -404,7 +414,7 @@ function reporting.CalculateIncomeTax.execute(args, context, kinds_for_account,
id = nil, id = nil,
transaction_id = nil, transaction_id = nil,
description = nil, description = nil,
account = 'HELP', account = HELP,
quantity = study_loan_repayment, quantity = study_loan_repayment,
commodity = context.reporting_commodity, commodity = context.reporting_commodity,
quantity_ascost = study_loan_repayment, quantity_ascost = study_loan_repayment,
@ -413,7 +423,7 @@ function reporting.CalculateIncomeTax.execute(args, context, kinds_for_account,
id = nil, id = nil,
transaction_id = nil, transaction_id = nil,
description = nil, description = nil,
account = 'Income Tax Control', account = INCOME_TAX_CONTROL,
quantity = -study_loan_repayment, quantity = -study_loan_repayment,
commodity = context.reporting_commodity, commodity = context.reporting_commodity,
quantity_ascost = -study_loan_repayment, quantity_ascost = -study_loan_repayment,
@ -436,7 +446,7 @@ function reporting.CalculateIncomeTax.execute(args, context, kinds_for_account,
id = nil, id = nil,
transaction_id = nil, transaction_id = nil,
description = nil, description = nil,
account = 'Income Tax Control', account = INCOME_TAX_CONTROL,
quantity = balance, quantity = balance,
commodity = context.reporting_commodity, commodity = context.reporting_commodity,
quantity_ascost = balance, quantity_ascost = balance,
@ -492,9 +502,9 @@ function entries_for_kind(kind: string, invert: boolean, balances:{ [string]: nu
-- Some exceptions for the link -- Some exceptions for the link
local link: string | nil local link: string | nil
if account == 'Current Year Earnings' then if account == CURRENT_YEAR_EARNINGS then
link = '/income-statement' link = '/income-statement'
elseif account == 'Retained Earnings' then elseif account == RETAINED_EARNINGS then
link = nil link = nil
else else
link = '/transactions/' .. account link = '/transactions/' .. account